[DX-981] Upgrade @ably/chat to v1.3.1 and remove msgpack workaround#194
Merged
umair-ably merged 2 commits intomainfrom Mar 26, 2026
Merged
[DX-981] Upgrade @ably/chat to v1.3.1 and remove msgpack workaround#194umair-ably merged 2 commits intomainfrom
umair-ably merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
umair-ably
force-pushed
the
upgrade-chat-sdk
branch
from
c9da699 to
273dff3
Compare
umair-ably
force-pushed
the
upgrade-chat-sdk
branch
from
273dff3 to
08509ac
Compare
umair-ably
changed the title
Contributor
|
|
sacOO7
reviewed
Mar 26, 2026
package.json
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| "jsonwebtoken": "^9.0.3", |
Just a minor comment, because jsonwebtoken:9.0.2 installation fails for node 25.3.0
Contributor
There was a problem hiding this comment.
It works for latest version 9.0.3
The new Chat SDK version fixes the MsgPack/binary protocol issue with realtime.request() REST calls, so the getClientOptions override that set useBinaryProtocol=false is no longer needed.
umair-ably
force-pushed
the
upgrade-chat-sdk
branch
from
fa690de to
0fcd0ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ably/chatfrom1.0.0to1.3.1useBinaryProtocol = falseworkaround inChatBaseCommand— the new Chat SDK handles msgpack correctly so the override is no longer neededimport type * as Ably from "ably"importTest plan
pnpm preparesucceedspnpm exec eslint .— 0 errorspnpm test:unit— all 2209 tests pass